feat(v2): implement admin form delete logic feature #3612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
form-v2/logic/logic-redesign-1.0
to
form-v2/develop
March 24, 2022 03:22
no API calls yet
so the button does not cut off any logic badges
karrui
force-pushed
the
form-v2/logic/delete-logic-modal-2.0
branch
from
122bdf2 to
cc71f2d
Compare
tshuli
approved these changes
Mar 28, 2022
Yea, known issue with ChakraUI which I actually fixed upstream (chakra-ui/chakra-ui#4922) (via @seaerchin), but haven't back-ported it back into this repository. |
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR implements the delete logic feature.
Tracked by #3365
Solution
Features:
Before & After Screenshots
msw mock for deleting of logic has been added. Should be able to test deletion of logic.