Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): add and render form footer in PublicFormPage #3609

Merged
merged 4 commits into from
Mar 30, 2022

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Mar 18, 2022

Problem

This PR adds the missing form footer in public form pages. Prerequisite for captcha PR.

Solution

Features:

  • add and render FormFooter component in PublicFormPage component

Improvements:

  • feat: remove minimum widths on left spacer when displaying form if there are no section fields
    • It was causing form display to be lopsided when there are no sections to jump to
  • feat: pass down formBgColor prop from PublicFormContext
    • so it can be reused by form footer too

Known issues:
Links to Terms of Use and Privacy Policy does not work yet. Will be in a separate PR.
EDIT: Now tracked in #3656 and #3657

Before & After Screenshots

PublicFormPage should now display form footer.

@karrui karrui merged commit d1f1ca5 into form-v2/develop Mar 30, 2022
@karrui karrui deleted the form-v2/public-form-footer branch March 30, 2022 08:28
@justynoh justynoh mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants