-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move notification banner back to top and add banner type capabilities #359
Conversation
# Conflicts: # src/public/modules/core/css/admin-form-header.css
EDIT: fixed in dbb3be0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor suggestions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments/questions. tbh I'm not really sure what's going on in a lot of the CSS changes, I'm assuming they are refactors and you've tested them!
|
Problem
The current notification banners are not obvious enough, and may result in users missing the banner.
This PR updates the placement of the banners to the top, whilst changing the CSS to ensure no elements are blocked by banners if they exist.
Closes https://github.com/datagovsg/formsg-private/issues/28
Solution
Features:
banner.client.component
, along with documentation inDEPLOYMENT_SETUP.md
Improvements:
scroll-to-id
directive and use $anchorScrollBug Fixes:
Screenshots
AFTER:
Desktop GIF run-through:
Mobile GIF run-through:
https://streamable.com/20m5k9
Public form banner is now sticky: