Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure clicking field opens to field editor #3583

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

mantariksh
Copy link
Contributor

Problem

Previously, when the builder drawer was closed, clicking on a
form field would open the drawer to the field list instead of
directly to the editing page for that field. This was because
of a useEffect which set fields to inactive whenever the active
tab changed.

Instead, we want to set the fields to inactive only when the active
tab is not the builder.

Solution

Check that the currently active tab isn't the Build tab before setting
fields to inactive.

Before

fix_drawer_before

After

fix_drawer_after

Previously, when the builder drawer was closed, clicking on a
form field would open the drawer to the field list instead of
directly to the editing page for that field. This was because
of a useEffect which set fields to inactive whenever the active
tab changed.

Instead, we want to set the fields to inactive only when the active
tab is not the builder.
@mantariksh mantariksh merged commit f2f5852 into form-v2/develop Mar 16, 2022
@mantariksh mantariksh deleted the form-v2/fix-edit-drawer branch March 16, 2022 07:43
@justynoh justynoh mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants