fix: ensure clicking field opens to field editor #3583
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously, when the builder drawer was closed, clicking on a
form field would open the drawer to the field list instead of
directly to the editing page for that field. This was because
of a useEffect which set fields to inactive whenever the active
tab changed.
Instead, we want to set the fields to inactive only when the active
tab is not the builder.
Solution
Check that the currently active tab isn't the Build tab before setting
fields to inactive.
Before
After