Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2/Dropdown): allow controlled selectedItems, render icon in MultiSelectItem #3561

Merged
merged 7 commits into from
Mar 14, 2022

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Mar 9, 2022

Problem

This PR cherry picks a bunch of SingleSelect/MultiSelect fixes that were encountered whilst working on #3556.

Solution

Features:

  • feat(Select): allow setting of empty placeholder
  • feat(MultiSelectItem): show icon in tag if it exists

Bug Fixes:

  • fix(ComboboxClearButton): show active state if item has been selected
    • Previously, the clear button will remain in inactive styling even if item has been selected
  • fix(Single/MultiSelectProvider)!: allow control of selectedItem, refilter items whenever items prop changes
    • Instead of using initialSelectedItem prop, allow users of the component to pass in current value for selection.
  • fix(SingleSelectProvider): use label string as aria-live announcement
    • the value was used previously, which may cause screenreaders to read something different that what is being rendered.

Before & After Screenshots

Most stories should not have a change. The only changes should be the ones for rendering an icon in the selected items in MultiSelect.

Copy link
Contributor

@tshuli tshuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits but lgtm otherwise!

@karrui karrui merged commit a533b4d into form-v2/develop Mar 14, 2022
@karrui karrui deleted the form-v2/select-dropdown-fixes branch March 14, 2022 05:40
@justynoh justynoh mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants