feat: export shared types for use in client/backend, update user route error to return new status code, update SettingsDto return #3504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is used to decide what fields are returned by getSettings form model method.
this means this new field will be returned by getSettings in the server for storage mode forms
this is for allowing type narrowing to happen
React code clears localStorage whenever a 401 is returned, and 404 probably works fine for an invalid OTP response (in that the given OTP has not been found in the "correct OTP" pile)
karrui
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR is part of #3472, where types that can be shared with client/server are exported.
In addition, update user route's
InvalidOtpErrorto return404instead of401status code, due to React app logging user out automatically when 401 is retrieved.Also also updates the fields SettingsDto returns to:
responseModein returned JSONpublicKeyfield in storage mode forms