feat(v2): add (and render) public form date field #3393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still requires rendering of disabled dates, error states in inputs, etc
Unable to add date picker selection tests... I think the rendered test block is too big. Jest will timeout. Probably worth it just to do the input validation tests
mantariksh
approved these changes
Feb 15, 2022
with that removed, we do not need a focus guard with a higher tab index
also extract theme into easier to manage constants
type error since the remaining type is "never"
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR adds the
DateFieldcomponent and renders it in the public form page.The relevant validations have been added.
Closes #2618
Solution
Features:
DateFieldcomponentImprovements:
Before & After Screenshots
In storybook
Tests
Unit tests for the field component has been added.