Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Release 5.41.1 hotfix #3335

Merged
merged 6 commits into from
Jan 27, 2022
Merged

build: Release 5.41.1 hotfix #3335

merged 6 commits into from
Jan 27, 2022

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Jan 26, 2022

Problem

  • The dependency upgrades in 5.41.0 broke the release although they passed the unit tests
  • This hotfix reverts the dependency upgrades made in 5.41.0 and cherry picks the following commits
  • For the next release, we will re-enable some basic e2e tests to identify the problematic dependency upgrades before proceeding

Fixes

  • chore: fix secrets check #3330
  • fix: correct busboy filename extraction when utf8 filenames are used #3303
  • Update secrets-check.sh #3287

Dep updates

  • fix(deps): bump node-fetch from 2.6.6 to 2.6.7 #3321

tshuli and others added 6 commits January 26, 2022 13:28
@tshuli
Revert "Merge pull request #3331 from opengovsg/release-5.41.0"
05abe95 
This reverts commit 0988f57, reversing
changes made to 86edbd7.
@karrui @tshuli
fix: correct busboy filename extraction when utf8 filenames are used (#…
427fba3 
…3303)

* test(email-submission): add failing test for utf8 filenames

* fix(email-submission): correctly process utf8 encoded file names
@zxt-tzx @tshuli
Update secrets-check.sh (#3287)
d0a45ac
@tshuli
chore: fix secrets check (#3330)
82af65d
@dependabot @tshuli
fix(deps): bump node-fetch from 2.6.6 to 2.6.7 (#3321)
bf1b15d 
Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.6 to 2.6.7.
- [Release notes](https://github.com/node-fetch/node-fetch/releases)
- [Changelog](https://github.com/node-fetch/node-fetch/blob/main/docs/CHANGELOG.md)
- [Commits](node-fetch/node-fetch@v2.6.6...v2.6.7)

---
updated-dependencies:
- dependency-name: node-fetch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@tshuli
chore: bump version to 5.41.1
0a2e8c8
@tshuli tshuli mentioned this pull request Jan 26, 2022
Closed
@tshuli tshuli requested review from karrui and mantariksh January 26, 2022 12:32
@tshuli tshuli merged commit 4ba324a into release Jan 27, 2022
@tshuli tshuli deleted the release-5.41.1-hotfix branch January 27, 2022 03:40
@tshuli tshuli restored the release-5.41.1-hotfix branch January 27, 2022 07:03
This was referenced Jan 28, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrui karrui karrui approved these changes

@mantariksh mantariksh Awaiting requested review from mantariksh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tshuli @karrui @zxt-tzx