-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Using neverthrow
to explicitly handle errors in AuthController
#332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrui
force-pushed
the
feat/neverthrow
branch
12 times, most recently
from
September 18, 2020 01:54
5852802
to
a519fbe
Compare
It will now install a pinned version of localstack and use the chrome addon instead of downloading from apt
karrui
force-pushed
the
feat/neverthrow
branch
from
September 18, 2020 10:32
a519fbe
to
8046f04
Compare
I'm so happy this passes now |
mantariksh
suggested changes
Sep 21, 2020
# Conflicts: # .travis.yml
mantariksh
approved these changes
Sep 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nicely done! thank you for all the prior research and experimentation as well!
liangyuanruo
changed the title
feat: apply FP using
feat: Using Sep 21, 2020
neverthrow
to explicitly handle errors in AuthControllerneverthrow
to explicitly handle errors in AuthController
liangyuanruo
approved these changes
Sep 21, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is an extension PR for #215 to implement explicit error handling to the endpoints.
Solution
Improvements:
neverthrow
's FP-likeResult
class to return either successok
s orerror
tracks for entireAuth
module endpointsTests
AuthService
andMailService
New dependencies:
neverthrow^2.7.1
- used to implement FP-like error handling