build: [master] Release 4.34.1 #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: merge Release 4.33.0 into develop
…247) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 3.3.0 to 3.10.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v3.10.1/packages/parser) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix(deps): bump ajv from 5.5.2 to 6.12.4 Bumps [ajv](https://github.com/ajv-validator/ajv) from 5.5.2 to 6.12.4. - [Release notes](https://github.com/ajv-validator/ajv/releases) - [Commits](ajv-validator/ajv@v5.5.2...v6.12.4) Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): remove ajv as dependency Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Antariksh Mahajan <[email protected]>
…e model (#244) * fix(FormModel): return discriminated model only after compiling base * fix(SubmissionModel): return discriminated model after compiling base * Fix tests Co-authored-by: Arshad Ali <[email protected]>
* chore(deps-dev): bump prettier from 2.0.5 to 2.1.1 Bumps [prettier](https://github.com/prettier/prettier) from 2.0.5 to 2.1.1. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/master/CHANGELOG.md) - [Commits](prettier/prettier@2.0.5...2.1.1) Signed-off-by: dependabot[bot] <[email protected]> * chore: lint Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Antariksh Mahajan <[email protected]>
* fix: set endpoint URL to s3-only port * refactor: use promisify instead of promise constructor * fix: add back mock creds, throw error if not present * docs: add docs for AWS credentials under main app env vars * build: empty commit to restart builds
* Move webhooks service into webhook module * Rename webhooks.service to webhook.service * Move webhook types into webhook module folder * Move webhook.controller into modules file * Move webhook utils to webhook modules folder * Convert webhook controller to typescript * Convert webhook controller to typescript * Move webhook controller tests into util.spec and service.spec * Refactor webhook service to return promises for testing purposes * Convert to arrow function * Remove declaration of submission model as compilation is done by the discriminator model itself * Add types to webhook service spec * Remove extra line and add jsdoc for response * Add comment about moving away from middleware pattern * Add comment that pushData should not be awaited upon * Add JSDoc to webhook service functions * Convert to await/async for better readability Co-authored-by: Arshad Ali <[email protected]>
Bumps [jest](https://github.com/facebook/jest) from 26.2.2 to 26.4.2. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md) - [Commits](jestjs/jest@v26.2.2...v26.4.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint](https://github.com/eslint/eslint) from 7.7.0 to 7.8.1. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v7.7.0...v7.8.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.20. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.19...4.17.20) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: uninstall raven-js * feat: install new sentry packages * feat: import and init new sentry module * docs: replace Raven with Sentry
The following environment variables are deprecated by Nodemailer and no lnoger in use in production * SES_RATE * SES_RATELIMIT Additionally addressed linting issues in the deployment setup Markdown file.
* chore: remove form_field.isFutureOnly key * chore: script to remove isFutureOnly from db * chore: remove get * style: shift new scripts to remove-isfutureonly-key.js * lint: remove trailing commas in script
* refactor: remove unused factory * refactor: use const instead of var * feat: catch error from getfeatureStates * refactor: capitalise f in getFeatureStates
* Move session secret to config * Move port to config * Move otpLifeSpan, bounceLifeSpan and submissionsTopUp to config * Move appConfig to config * Move formsgSdkMode to config * Move awsConfig to config * Move types out * Move cspReportUri and chromiumBin to config * Fix bugs with config loading * Move banners and custom watch grp to config * Move dbHost to config * Remove deprecated env vars * Move ses to convict and enforce that prod ses are defined * Remove repeated code to check bucket url * Reorganise banner env vars under banner key/header * Add missing env var to documentation and re-organise CSP_REPORT_URI' * Reorganise based on order in documentation * Move nodeEnv to convict * Move bucket urls to own convict that gets validated after * Move schemas to separate file * Fix format of nodeEnv * Edit nodemailer configuration to be based on environment * Reorganise and add comments * Remove convict config to Vars for clarity * Add types to convict schemas * Fix typing issues * Add documentation on FORMSG_LOCALSTACK_ENDPT * Reorganise for better readability * Fix bug with db host * Remove test env vars that no longer need to be unset * Use getProperties so that typing can be enforced * Remove warn validation on dev environment * Remove default for session secret * Add defaults for chromium bin * Add validation for db host * Split schemas into option, compulsory and prodOnly * Fix typing * Use new schemas and load dbUri based on environment * Update package * Remove env vars that don't need to be defined during tests * Move cspReportUri to sentry feature, enforce type url and only pass to Helmet if defined * Add missing documentation * Simplify logic * Remove otpGenerator * Define defaults directly in schema * Validate aws endpoint * Move defaults to constant file * Fix imports for constants file * Update default for bounceLifeSpan * Mark the relevant env vars as being sensitive * Add todo to clean up MyInfo env vars * Reference issue in todo * Move aws default endpoint to aws endpoint env var and enforce region in production urls * Fix rebase issues * Remove FORMSG_LOCALSTACK_ENDPT * Remove logger from config * Require config in logger now that config does not use logger * Remove aws region default * Use config.nodeEnv instead of process.env * Update docs/DEPLOYMENT_SETUP.md Co-authored-by: Antariksh Mahajan <[email protected]> * Update docs/DEPLOYMENT_SETUP.md Co-authored-by: Antariksh Mahajan <[email protected]> * Add AWS_ENDPOINT to docker file for dev purposes * Add comments to specify how convict defaults work * Add a session secret default for dev environment * Add default for aws endpoint in docker dev file Co-authored-by: Arshad Ali <[email protected]> Co-authored-by: Antariksh Mahajan <[email protected]>
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.11.0 to 7.11.5. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.11.5/packages/babel-preset-env) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [testcafe](https://github.com/DevExpress/testcafe) from 1.8.6 to 1.9.1. - [Release notes](https://github.com/DevExpress/testcafe/releases) - [Changelog](https://github.com/DevExpress/testcafe/blob/master/CHANGELOG.md) - [Commits](DevExpress/testcafe@v1.8.6...v1.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.10.2 to 7.11.5. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.11.5/packages/babel-core) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#273) * fix: fix invocations of logger that does not adhere to expected shape * feat(UserController): update error log message to be constants
* feat: add try-catch block to custom logger for js files JavaScript files will not throw any error when the wrong argument signature is passed into logger invocations. Add try catch block as a defensive measure at least until the application is 100% typescript, to prevent possible errors from being thrown due to the wrong type * fix(logger): add stricter shape checks * fix: use correct parameters in info logging Co-authored-by: Antariksh Mahajan <[email protected]> Co-authored-by: Antariksh Mahajan <[email protected]>
* Edit tool tips * Configure mobile directive should open verified sms modal * Remove unused css that prevents modal from stacking * Only show modal when toggling on verified sms * Ensure that supportFormLink is defined in verified sms modal * lint Co-authored-by: Arshad Ali <[email protected]>
…t-eslint/parser (#246) * chore(deps-dev): bump @typescript-eslint/eslint-plugin Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 3.9.1 to 4.0.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.0.0/packages/eslint-plugin) Signed-off-by: dependabot[bot] <[email protected]> * chore(dev-deps): bump @typescript-eslint/parser from 3.10.1 to 4.0.0 This was causing the lint errors from the upgrade of @typescript-eslint/eslint-plugin as the parser used was still of a lower level * chore: update eslintrc to use recommended Typescript eslint rules * lint: run linter on Typescript codebase using new rules * chore(deps-dev): bump @typescript-eslint/eslint-plugin to 4.0.1 * refactor(Bounce): add stricter RequestHandler typing to handleSns * fix(MailUtils): add stricter typing to AutoreplyHtmlData typing * refactor: set user betaFlags typing to be stricter to be empty object * refactor(Bounce): update typing of ResBody to be never in handleSns Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kar Rui Lau <[email protected]>
Snyk has created this PR to upgrade mongoose from 5.9.19 to 5.10.0. See this package in npm: https://www.npmjs.com/package/mongoose See this project in Snyk: https://app.snyk.io/org/liangyuanruo/project/16bd7aff-aa19-4364-adc4-7b79c42b7ce0?utm_source=github&utm_medium=upgrade-pr
…280) Bumps [stylelint-config-prettier](https://github.com/prettier/stylelint-config-prettier) from 8.0.1 to 8.0.2. - [Release notes](https://github.com/prettier/stylelint-config-prettier/releases) - [Commits](prettier/stylelint-config-prettier@v8.0.1...v8.0.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…n Design (#215) * refactor: introduces nested routing in TS * doc: add better documentation for functions * chore: add eslint for all "*.spec.ts" files * test(jestExpress): enhance mockResponse creation - mockResponse now allows injection of other response-related keys used to setup all the middlewares that helps in testing * test(AuthRoutes): add /checkuser integration tests * fix: update tsconfig.build.json to exclude spec files and public * test: add CookieStore helper class to store cookies for auth'd routes * Introduces ApplicationError as an abstract class for extension - this prevents developers from using ApplicationError directly and are forced to extend from the class (in Typescript).
* refactor: move bounce model into module * refactor: inline tests * refactor: move helpers into util * feat: log admin responses to main log group * feat: log all critical bounces * refactor: use absolute paths in tests * fix: fix constants import * feat: log submission ID for critical bounces * test: allow varying email type * test: update tests for bounce service * test: ignore __tests__ for coverage * test: add test for short term logs * build: ignore tests for compilation * refactor: rename bounce-helpers to bounce-test-helpers * refactor: avoid using lodash get * refactor: convert EMAIL_TYPES to enum * refactor: change log action to calling method * refactor: change CRITICAL BOUNCE to sentence case * refactor: move isCriticalBounce into domain * refactor: move typeguards into util * refactor: avoid typecast for IBounceNotification * refactor: call logCriticalBounce only once * refactor: remove setting of hasAlarmed * refactor: extract function for logging raw notif * docs: add TODO to convert bounceType to enum * refactor: use typeguard to check recipients * fix: convert formId to string * fix: set hasAlarmed * refactor: collapse save calls * refactor: add bounceInfo key explicitly
mantariksh
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.