Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(builder/3): allow form fields reordering in form builder #3134

Merged
merged 6 commits into from
Jan 14, 2022

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Dec 2, 2021

This PR is part of the chain for form-v2/feat/builder branch.

Problem

This PR adds the reordering form fields feature.

Closes #3132

Solution

Features:

  • feat: add drag and drop functionality to form builder field rows
  • feat: add reorder form field mutation with optimistic updates
  • feat: prevent reordering when field mutations are in flight

Improvements:

  • fix(FieldContainer): remove unnecessary spacing below each field

Bug Fixes:

  • fix(FieldRowContainer): remove transitionDuration, use transition
    • fixes wonky element jumping during sort reordering. transition now only focuses on background

Before & After Screenshots

None............... sorry

Tests

OK SOON

Deploy Notes

New dependencies:

  • react-beautiful-dnd : accessible drag and drop

@karrui karrui force-pushed the form-v2/feat/builder/sortable-field-rows-3 branch from f276cc1 to 5869c5c Compare December 2, 2021 10:17
@karrui karrui force-pushed the form-v2/feat/builder/checkbox-field-preview-2 branch from 75d4ec4 to 0389028 Compare December 2, 2021 10:17
@karrui karrui force-pushed the form-v2/feat/builder/sortable-field-rows-3 branch 2 times, most recently from 837227b to 4b6eec4 Compare January 13, 2022 08:24
@karrui karrui requested a review from liangyuanruo January 13, 2022 09:14
@karrui karrui marked this pull request as ready for review January 13, 2022 09:14
@karrui karrui force-pushed the form-v2/feat/builder/checkbox-field-preview-2 branch from 0d15754 to d440555 Compare January 14, 2022 11:39
@karrui karrui force-pushed the form-v2/feat/builder/sortable-field-rows-3 branch from 4b6eec4 to 3f8d692 Compare January 14, 2022 11:39
Base automatically changed from form-v2/feat/builder/checkbox-field-preview-2 to form-v2/develop January 14, 2022 11:51
@karrui karrui force-pushed the form-v2/feat/builder/sortable-field-rows-3 branch from 3f8d692 to f690d8c Compare January 14, 2022 13:07
@karrui karrui merged commit 3bea220 into form-v2/develop Jan 14, 2022
@karrui karrui deleted the form-v2/feat/builder/sortable-field-rows-3 branch January 14, 2022 13:26
@justynoh justynoh mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant