-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(builder/1): add initial field preview (only SectionField) when editing field in form builder #3130
Merged
karrui
merged 16 commits into
form-v2/develop
from
form-v2/feat/builder/edit-field-preview-1
Jan 14, 2022
Merged
feat(builder/1): add initial field preview (only SectionField) when editing field in form builder #3130
karrui
merged 16 commits into
form-v2/develop
from
form-v2/feat/builder/edit-field-preview-1
Jan 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrui
changed the title
feat(builder/1): add field preview when editing field in form builder
feat(builder/1): add initial field preview (only SectionField) when editing field in form builder
Dec 2, 2021
karrui
force-pushed
the
form-v2/feat/builder/layout-render-0
branch
from
December 2, 2021 10:17
658e700
to
bf23514
Compare
karrui
force-pushed
the
form-v2/feat/builder/edit-field-preview-1
branch
from
December 2, 2021 10:17
86b1e9d
to
fbde509
Compare
Base automatically changed from
form-v2/feat/builder/layout-render-0
to
form-v2/develop
January 13, 2022 07:11
There are a variety of packages that do the same thing, but seems like the use-debounce package actually took the most precautions to prevent unnecessary re-renders, which I appreciate.
in the end... only needed to call a specific debounced function instead of invoking it
pre was the wrong choice -- long single words overflow out of the bounding containers
karrui
force-pushed
the
form-v2/feat/builder/edit-field-preview-1
branch
from
January 13, 2022 08:18
fbde509
to
5b1d90f
Compare
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the chain for
form-v2/feat/builder
branch.Problem
This PR adds logic for allowing of real time (but debounced) preview on the field when it is being edited.
Part of #2792
Solution
Features:
Improvements:
Bug Fixes:
Before & After Screenshots
None... Will add
Tests
Deploy Notes
New dependencies:
zustand
: state management for managing edit form state without rerendering often (due to context)immer
: immutable mutationsreact-use
: react hooks, mainly using useDebounce for now (treeshakeable anyways)