Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): correct set routes for AdminFormPage stories #3038

Merged
merged 1 commit into from
Nov 15, 2021
Merged

feat(v2): correct set routes for AdminFormPage stories #3038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/features/admin-form/AdminFormBuilderPage.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export default {
// MemoryRouter is used so react-router-dom#Link components can work
// (and also to force the initial tab the page renders to be the settings tab).
return (
<MemoryRouter initialEntries={['/:formId']}>
<MemoryRouter initialEntries={['/12345']}>
<Routes>
<Route path={'/:formId'} element={<AdminFormLayout />}>
<Route index element={storyFn()} />
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/features/admin-form/AdminFormResponsesPage.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ export default {
// MemoryRouter is used so react-router-dom#Link components can work
// (and also to force the initial tab the page renders to be the settings tab).
return (
<MemoryRouter initialEntries={['/:formId']}>
<MemoryRouter initialEntries={['/12345/responses']}>
<Routes>
<Route path={'/:formId'} element={<AdminFormLayout />}>
<Route index element={storyFn()} />
<Route path="responses" element={storyFn()} />
</Route>
</Routes>
</MemoryRouter>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/features/admin-form/AdminFormSettingsPage.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default {
// MemoryRouter is used so react-router-dom#Link components can work
// (and also to force the initial tab the page renders to be the settings tab).
return (
<MemoryRouter initialEntries={['/:formId/settings']}>
<MemoryRouter initialEntries={['/12345/settings']}>
<Routes>
<Route path={'/:formId'} element={<AdminFormLayout />}>
<Route path="settings" element={storyFn()} />
Expand Down