Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: document env vars needed for EFS #303

Merged
merged 2 commits into from
Sep 9, 2020
Merged

chore: document env vars needed for EFS #303

merged 2 commits into from
Sep 9, 2020

Conversation

arshadali172
Copy link
Contributor

No description provided.

liangyuanruo
liangyuanruo approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@liangyuanruo liangyuanruo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also consider dividing the features between compulsory and optional, so that it's easy to tell at a glance what is the minimum viable deployment.

@arshadali172
Copy link
Contributor Author

Also consider dividing the features between compulsory and optional, so that it's easy to tell at a glance what is the minimum viable deployment.

@liangyuanruo this is already under the additional features section. Do you mean dividing the spcp env vars into optional/compulsory?

@arshadali172 arshadali172 changed the title Document env vars needed for EFS chore: document env vars needed for EFS Sep 9, 2020
@liangyuanruo liangyuanruo merged commit 2e4c80c into develop Sep 9, 2020
@liangyuanruo liangyuanruo deleted the document-efs-vars branch September 9, 2020 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangyuanruo liangyuanruo liangyuanruo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arshadali172 @liangyuanruo