Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): Implement ParagraphField component, extend markdown components #3000

Merged
merged 5 commits into from
Nov 1, 2021

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Oct 27, 2021

Problem

This PR implements a field renderer for the Paragraph field (aka the field formally known as Statement).
Also extends useMarkdown to render correct ol and li tags using Chakra's OrderedList and ListItem component.

Closes #2604

Solution

Features:

  • feat: convert markdown list related tags to ChakraUI versions
  • feat(StatementField): add components and stories
  • test(utils): add extended utils to search for text within nested tags

Before & After Screenshots

New stories have been added to storybook

Tests

new unit tests have been added for the StatementField component

@karrui karrui changed the title feat(v2): Implement StatementField component, extend markdown components feat(v2): Implement ParagraphField component, extend markdown components Nov 1, 2021
@karrui karrui merged commit fa95275 into form-v2/develop Nov 1, 2021
@karrui karrui deleted the form-v2/feat/statement-field-component branch November 1, 2021 13:39
@justynoh justynoh mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant