feature: release 4.34.0

[arshadali172]

New

• Verified sms modal

Refactor

• Migrate /auth endpoint handling to Typescript
• Remove form_field.isFutureOnly
• Remove redundant feature factory
• Use convict for configuration
• Add try-catch block to custom logger for js files
• Remove unused Nodemailer env vars
• Typify webhook and migrate from middleware pattern
• Prevent discriminated models from being created before their base model

Misc

• Upgrade localstack version
• Upgrade Sentry SDK
• Various dependency version bumps
  • stylelint-config-prettier 8.0.1 to 8.0.2
  • mongoose 5.9.19 to 5.10.0
  • babel/core 7.10.2 to 7.11.5
  • testcafe 1.8.6 to 1.9.1
  • babel/preset-env 7.11.0 to 7.11.5
  • lodash 4.17.19 to 4.17.20
  • eslint 7.7.0 to 7.8.1
  • jest 26.2.2 to 26.4.2
  • prettier 2.0.5 to 2.1.1
  • typescript-eslint/parser 3.3.0 to 3.10.1
  • typescript-eslint/parser 3.10.1 to 4.0.0
  • typescript-eslint/eslint-plugin 3.9.1 to 4.0.0
  • ajv 5.5.2 to 6.12.4

[arshadali172]

Configuration Improvements (@shuli-ogp )

• Test unfurling of form urls on whatsapp/facebook/twitter
• Test email submission with all fields
• Test encrypt submission with all fields
• Create form
• Test SingPass/MyInfo submission
• Test CorpPass submission

Feature Manager (@shuli-ogp) ~ test on staging alt

• Test email submission
• Test encrypt submission
• Create form flow

[arshadali172]

Auth Refactoring (@arshadali172 )

• Sign out should work properly
• Logging in to existing user should work properly
  • Invalid OTP should return 422 with invalid OTP message
  • Entering wrong OTP 10 times should return 422, and subsequently entering correct OTP will still return 422.
  • Requesting for new OTP should work, and login successfully
• Attempt to login as a new user by logging in with your open.gov.sg email; e.g. <youremail>[email protected]
  • Should create new user successfully upon log in, test with creating a form, log out and log back in. Your form should still be there.

Intranet/IE (@arshadali172 )

• Test upload image/logo (Does not work, may be whitelisting issue)
• Download csv/attachments
• Test email submission
• Test encrypt submission

Verified SMS (@arshadali172 )

• Include verified sms modal on desktop view, triggered on verified sms toggle
• Include verified sms modal on mobile view, triggered on verified sms toggle
• Link contact us to support form

Sentry

• Test that sentry events are logged

[arshadali172]

Webhook Refactoring (@mantariksh)

• Test webhook sending and decryption using ngrok
• Test TemperatureSG

Date (@mantariksh)
Create 5 date fields in admin view with the following options. Test that the validations work in the preview panel datepicker on the right (i.e. the popup calendar).

• Disallow past dates
• Disallow future dates
• Custom date range with Min Date only
• Custom date range with Max Date only
• Custom date range with both Min and Max Date

Validation for date range validation option in admin view

• Check that it is not possible for admin to save a form with a custom date range where both Min and Max date are left blank
• Check that it is not possible for admin to save a form with a custom date range where Max date is before Min date

Able to submit forms correctly

• Publish the form. Test that all 5 date field validations still work in the public form datepicker (i.e. the popup calendar)
• Test that all 5 date field validations still work in the public form using manual input to the date field and manual input of date outside the validation range is rejected

Test for editing and reordering, instead of creating

• Using the existing form fields, shuffle the form validations of the five fields by editing the validation options
• Reorder the form fields
• Repeat the above tests to make sure the date validations remain correct