feat(v2): Implement TableField component #2945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Want to use new type RequireAllOrNone
when addMoreRows is present, maximumRows must also be present
and update stories
requires wrapping the entire table with a wrapper (instead of setting display in the table tag) to correctly set width of each table cell
remnant of an old commit
TableField is a special variant of Tables and should not be made default
# Conflicts: # frontend/package-lock.json # frontend/package.json # frontend/src/utils/fieldValidation.ts
# Conflicts: # frontend/package-lock.json # frontend/package.json
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR implements a field renderer for the
Tablefield.Closes #2485, #2621
Solution
Features:
TableFieldcomponent (and subcomponents)Improvements:
UtilitiesstoryFormLabelcomponent propsBefore & After Screenshots
New stories have been added in Storybook.
Deploy Notes
New environment variables:
env var: env var detailsNew scripts:
script: script detailsNew dependencies:
type-fest: update versions insharedto v2.5.0, install infrontendreact-table: headless renderer for tables in React