feat(FormSettings/4): add storage mode form activation modal #2939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrui
changed the title
karrui
force-pushed
the
form-v2/feat/settings/storage-activation-4
branch
from
6f6a7b5 to
360b179
Compare
karrui
force-pushed
the
form-v2/feat/settings/email-general-settings-3
branch
from
b6fd0b9 to
a6628f8
Compare
karrui
force-pushed
the
form-v2/feat/settings/storage-activation-4
branch
from
a80360a to
e8a6bee
Compare
karrui
force-pushed
the
form-v2/feat/settings/email-general-settings-3
branch
from
a6628f8 to
2b9a463
Compare
karrui
force-pushed
the
form-v2/feat/settings/storage-activation-4
branch
from
e8a6bee to
bcaed09
Compare
karrui
force-pushed
the
form-v2/feat/settings/email-general-settings-3
branch
from
2b9a463 to
704a664
Compare
Base automatically changed from
form-v2/feat/settings/email-general-settings-3
to
form-v2/develop
October 28, 2021 08:27
this is to facilitate the checking of puiblic key when activating a storage mode form
somehow the name SectionKeyActivationModal made sense to me whilst I was writing it... it has now been correctly renamed
karrui
force-pushed
the
form-v2/feat/settings/storage-activation-4
branch
from
bcaed09 to
8245c05
Compare
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR builds on #2891
Problem
This PR adds the check for the form's public-secret keypair validity before allowing the form to be activated.
Extra MSW handlers have been added to allow for the manipulation of form settings (to test the appearance of the storage mode form).
Solution
Breaking Changes
publicKeyprop is now returned ingetSettingsfor storage mode forms. This is an API change.Features:
SecretKeyActivationModalcomponent, with logic toImprovements:
Before & After Screenshots
The setting stories have been updated; manipulation of form settings is now possible.
Dependencies
@opengovsg/formsg-sdk: formsg sdk