Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FormSettings/2): add remaining general settings toggles #2890

Merged
merged 9 commits into from
Oct 28, 2021

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Sep 30, 2021

Note that this PR builds on #2889

Problem

This PR implements the remaining form setting toggles found in the general settings tab. EmailForm specific toggles will come in a later PR.

Related to #2789

Solution

Features:

  • add captcha section to general page
  • add FormLimitToggle component and related hooks
  • add FormCustomisationSection component
  • add error handling to mutations, including submission limit error handling and checks

Improvements:

  • useMutateFormSettings hook now exports mutation sub-hooks instead of creating new hooks for each mutation
  • add sticky navbar and setting sidebar

Before & After Screenshots

AdminFormPage/Settings stories have been updated.

@karrui karrui force-pushed the form-v2/feat/settings/initial-page-1 branch from 83cf3b8 to 74f5df3 Compare October 26, 2021 03:46
@karrui karrui force-pushed the form-v2/feat/settings/other-setting-toggles-2 branch from 78b0295 to 9014c9a Compare October 26, 2021 03:46
@karrui karrui force-pushed the form-v2/feat/settings/initial-page-1 branch from 74f5df3 to 86bed93 Compare October 26, 2021 08:12
@karrui karrui force-pushed the form-v2/feat/settings/other-setting-toggles-2 branch from 9014c9a to bba9b81 Compare October 26, 2021 08:12
@karrui karrui force-pushed the form-v2/feat/settings/initial-page-1 branch from 86bed93 to e2ae8f3 Compare October 28, 2021 07:57
Base automatically changed from form-v2/feat/settings/initial-page-1 to form-v2/develop October 28, 2021 08:11
@karrui karrui force-pushed the form-v2/feat/settings/other-setting-toggles-2 branch from bba9b81 to 4d278c8 Compare October 28, 2021 08:13
@karrui karrui merged commit c014201 into form-v2/develop Oct 28, 2021
@karrui karrui deleted the form-v2/feat/settings/other-setting-toggles-2 branch October 28, 2021 08:20
@justynoh justynoh mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant