Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PublicFormPage/1): set up initial route to load public form data #2864

Merged
merged 10 commits into from
Oct 26, 2021

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Sep 24, 2021

Note that there is a chain of PRs to set up the public form route

Problem

This PR sets up the routing for rendering public forms.

Part of #2601

Solution

Features:

  • feat: copy public form submission utils to public-form feature dir
  • feat: move PublicFormService to public-form feature dir
  • feat: add usePublicFormView react-query hook
  • feat: add placeholder PublicFormPage
  • feat: add route handling for public forms
  • feat: add better typings for public form param

@karrui karrui force-pushed the form-v2/feat/public-form-query-1 branch from 4454ad2 to 5256938 Compare October 25, 2021 07:17
Copy link
Contributor

@theMogget theMogget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just some small nits~

frontend/src/features/public-form/PublicFormService.ts Outdated Show resolved Hide resolved
frontend/src/features/public-form/queries.ts Show resolved Hide resolved
frontend/src/features/public-form/utils/formSubmission.ts Outdated Show resolved Hide resolved
@karrui karrui merged commit 96d3d3a into form-v2/develop Oct 26, 2021
@karrui karrui deleted the form-v2/feat/public-form-query-1 branch October 26, 2021 07:57
@justynoh justynoh mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants