Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(mergify): specify checks and include Snyk #2825

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

mantariksh
Copy link
Contributor

Problem

  • Mergify config does not specify each status check explicitly, against the recommendations of the docs
  • Snyk.io security upgrades are not included in the mergify config, so they have to be approved and merged manually

Closes #1749

Solution

  • Specify all status checks explicitly in mergify config
  • Include a config rule to approve and major non-major Snyk security upgrades

Screenshots

Taken from Mergify config editor.

Config passes for dependabot upgrades e.g. #2810

Screenshot 2021-09-21 at 10 45 58 AM

Config passes for Snyk security upgrades e.g. #2412

Note that the "potential rule" is because this PR was taken when our Snyk license was still under "Open Government Products", so the relevant GitHub branch protection doesn't pass. This should no longer be the case for newer PRs for which the license is under "FormSG".

Screenshot 2021-09-21 at 10 49 31 AM

Config does not pass for regular PRs e.g. #2776

Screenshot 2021-09-21 at 10 50 37 AM

Copy link
Contributor

@tshuli tshuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mantariksh mantariksh merged commit 35c3bcf into develop Sep 21, 2021
@mantariksh mantariksh deleted the build/update-mergify branch September 21, 2021 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mergify to integrate Snyk.io, and explicitly check success of each CI step
2 participants