feat(v2): add NumberField component for use when rendering forms #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantariksh
approved these changes
Aug 30, 2021
# Conflicts: # frontend/src/utils/fieldValidation.ts
|
Rerequesting review since there are some changes to number field |
mantariksh
approved these changes
Sep 2, 2021
timotheeg
approved these changes
Sep 7, 2021
# Conflicts: # frontend/src/utils/fieldValidation.ts
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR implements component that takes in a number field schema and creates a field with validation according to the schema.
Also has a fix in the base NumberInput component, passing the ref into the input so it can be focused by rhf on error.
Closes #2609
Fixes
Tests
Add unit tests using Storybook's stories
Deploy Notes
New dependencies:
simplur: easy pluralisation of strings