feat(design-system): add Toggle component and stories #2648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrui
reviewed
Aug 20, 2021
|
need to fix a11y, label is not linked to toggle |
mantariksh
force-pushed
the
form-v2/toggle-component
branch
from
8efc07d to
a9ab5ec
Compare
done |
mantariksh
force-pushed
the
form-v2/toggle-component
branch
from
a9ab5ec to
9fdffa1
Compare
Observation from design review was that the label and description repeat themselves as a result of the VisuallyHidden component, so it would be better to leave it out and rely on screen readers to read out the label and description in sequence.
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Toggle component.
Design considerations
Inclusion of icon in thumb
The original Chakra UI Switch implementation did not have the option to include an icon within the thumb (circular part of the Switch). Since we need to have icons in the thumb, I copied the implementation and adapted it to include the correct icon (checked/unchecked/disabled).