Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sms-limiting): hide counts when forms are onboarded #2585

Merged
merged 1 commit into from
Aug 16, 2021
Merged

fix(sms-limiting): hide counts when forms are onboarded #2585

merged 1 commit into from
Aug 16, 2021

Conversation

seaerchin
Copy link
Contributor

@seaerchin seaerchin commented Aug 13, 2021 •
edited
Loading

Problem

  1. Modal shows the counts when teh form is onboarded.

Solution

  1. Hide the count

@seaerchin seaerchin requested a review from karrui August 13, 2021 06:30
@seaerchin seaerchin mentioned this pull request Aug 13, 2021
Closed
@karrui
Copy link
Contributor

karrui commented Aug 16, 2021

Will force push to fix the testcafe thingamagic

@karrui karrui force-pushed the fix/hide-sms-counts branch from 36ad8ca to 11ac8c3 Compare August 16, 2021 04:05
@karrui karrui merged commit c3461dd into develop Aug 16, 2021
@karrui karrui deleted the fix/hide-sms-counts branch August 16, 2021 04:59
@tshuli tshuli mentioned this pull request Aug 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrui karrui karrui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seaerchin @karrui