Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add 10 MB max length checks to form field editor #2584

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

frankchn
Copy link
Contributor

Problem

Closes #1814

Solution

As discussed, adds relevant checks for field size on the form field editor itself.

@frankchn frankchn requested a review from mantariksh August 13, 2021 05:44
@mantariksh mantariksh changed the title fix: Add 10 MB max lnegth checks to form field editor fix: Add 10 MB max length checks to form field editor Aug 30, 2021
@mantariksh
Copy link
Contributor

frontend code tested and lgtm, but I'm rethinking our decision to remove the backend check. while the check doesn't run on every single update to the form (due to the nuances of findByIdAndUpdate as mentioned in the issue), I think it's still better to have it than to omit it, so it at least runs on the form updates which don't use findByIdAndUpdate. wdyt?

@frankchn
Copy link
Contributor Author

@mantariksh yeah I think that is fair, undoing the removal.

@mantariksh mantariksh merged commit 5494f4a into develop Aug 31, 2021
@mantariksh mantariksh deleted the frank/issue-1814 branch August 31, 2021 05:31
@karrui karrui mentioned this pull request Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-validate hooks not running
2 participants