chore: Move file-loader to dev-dependencies #2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Snyk is reporting an issue with an outdated version of ajv, which is reported as a sub dependency of [email protected].
This is a false positive however, due to an incorrect categorisation of the dependency. file-loader is a webpack module and is thus a dev-dependency which should not be reported by Snyk.
Approach
Move dependency to dev-dependency instead.
Note: [email protected] is 2 major versions behind (latest is 6.2.0 a the time of this PR), because our webpack tooling on FormSG is very much outdated. At some point, we should upgrade the whole tool chain to benefit from whatever improvements and optimisations are being released.