Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove frontend code to delete spcp cookie #2551

Merged
merged 2 commits into from
Aug 10, 2021

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Aug 9, 2021

Problem

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible (all affected cookies have expired)

New environment variables:

  • env var : env var details

OLD_SPCP_COOKIE_DOMAIN env var deleted

Tests

  • Create sp form and log in
    • Check that form can be submitted
    • Check that user can log out and jwt cookie is deleted thereafter
    • Log in again. Check that submission and log out works
  • Repeat above with 'remember me' enabled
  • Repeat above with CP form
  • Repeat above with MyInfo form
  • Repeat above with SGID form

@tshuli tshuli requested a review from karrui August 9, 2021 09:42
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with comment

Copy link
Contributor

@timotheeg timotheeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tshuli tshuli merged commit 5d81b20 into develop Aug 10, 2021
@tshuli tshuli deleted the feat/client-cookie-delete branch August 10, 2021 02:40
@karrui karrui mentioned this pull request Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TODO: Remove frontend code to delete spcp cookie
3 participants