Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix off by one for storage mode bulk attachment downloads #242

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

mantariksh
Copy link
Contributor

Problem

Question number for storage mode bulk download is off by one.

image

Solution

This is because there was a mistaken - 1 when setting the question number, so this was removed.

@mantariksh mantariksh requested a review from tshuli September 1, 2020 02:57
@mantariksh mantariksh changed the title fix: use original questionCount fix: fix off by one for storage mode bulk attachment downloads Sep 1, 2020
Copy link
Contributor

@tshuli tshuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tshuli tshuli merged commit bb096f8 into release-4.33.0 Sep 1, 2020
@tshuli tshuli deleted the atts-qn-count branch September 1, 2020 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants