Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct left margin in acknowledgment error when activating storage mode form #240

Merged
merged 2 commits into from
Sep 1, 2020
Merged

fix: correct left margin in acknowledgment error when activating storage mode form #240

merged 2 commits into from
Sep 1, 2020

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Sep 1, 2020

Problem

This PR fixes a small misalignment in the error message box when typing in the storage mode acknowledgment input.

Solution

Before & After Screenshots

BEFORE:
Screenshot 2020-09-01 at 10 24 52 AM

AFTER:
Screenshot 2020-09-01 at 10 24 42 AM

@karrui karrui requested review from mantariksh and tshuli September 1, 2020 02:27
@karrui karrui changed the base branch from develop to release-4.33.0 September 1, 2020 02:27
@mantariksh mantariksh merged commit 6facdae into release-4.33.0 Sep 1, 2020
tshuli
tshuli reviewed Sep 1, 2020
View reviewed changes
Copy link
Contributor

@tshuli tshuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@karrui karrui deleted the fix/activate-form-margin branch September 1, 2020 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshuli tshuli tshuli left review comments

@mantariksh mantariksh mantariksh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karrui @mantariksh @tshuli