Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump celebrate from 14.0.0 to 15.0.0 #2365

Merged
merged 2 commits into from
Jul 12, 2021
Merged

fix(deps): bump celebrate from 14.0.0 to 15.0.0 #2365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef088c5
fix(deps): bump celebrate from 14.0.0 to 15.0.0
dependabot[bot] Jul 11, 2021
568037e
fix(test): update tests to account for new celebrate error default msg
karrui Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
"boxicons": "1.8.0",
"bson-ext": "^2.0.5",
"busboy": "^0.3.1",
"celebrate": "^14.0.0",
"celebrate": "^15.0.0",
"compression": "~1.7.2",
"connect-mongo": "^4.4.1",
"convict": "^6.1.0",
Expand Down
32 changes: 8 additions & 24 deletions src/app/modules/form/admin-form/__tests__/admin-form.routes.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,9 +308,7 @@ describe('admin-form.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})

it('should return 400 when response is missing _id', async () => {
Expand All @@ -335,9 +333,7 @@ describe('admin-form.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})

it('should return 400 when response is missing fieldType', async () => {
Expand All @@ -362,9 +358,7 @@ describe('admin-form.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})

it('should return 400 when response has invalid fieldType', async () => {
Expand All @@ -391,9 +385,7 @@ describe('admin-form.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})

it('should return 400 when response is missing answer', async () => {
Expand All @@ -418,9 +410,7 @@ describe('admin-form.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})

it('should return 400 when response has both answer and answerArray', async () => {
Expand All @@ -445,9 +435,7 @@ describe('admin-form.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})

it('should return 400 when attachment response has filename but not content', async () => {
Expand All @@ -472,9 +460,7 @@ describe('admin-form.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})

it('should return 400 when attachment response has content but not filename', async () => {
Expand All @@ -499,9 +485,7 @@ describe('admin-form.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})
})

Expand Down
32 changes: 8 additions & 24 deletions src/app/modules/submission/email-submission/__tests__/email-submission.routes.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,9 +266,7 @@ describe('email-submission.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})

it('should return 400 when response is missing _id', async () => {
Expand All @@ -290,9 +288,7 @@ describe('email-submission.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})

it('should return 400 when response is missing fieldType', async () => {
Expand All @@ -314,9 +310,7 @@ describe('email-submission.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})

it('should return 400 when response has invalid fieldType', async () => {
Expand All @@ -340,9 +334,7 @@ describe('email-submission.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})

it('should return 400 when response is missing answer', async () => {
Expand All @@ -364,9 +356,7 @@ describe('email-submission.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})

it('should return 400 when response has both answer and answerArray', async () => {
Expand All @@ -388,9 +378,7 @@ describe('email-submission.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})

it('should return 400 when attachment response has filename but not content', async () => {
Expand All @@ -412,9 +400,7 @@ describe('email-submission.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})

it('should return 400 when attachment response has content but not filename', async () => {
Expand All @@ -436,9 +422,7 @@ describe('email-submission.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})
})

Expand Down
32 changes: 8 additions & 24 deletions src/app/routes/api/v3/admin/forms/__tests__/admin-forms.preview.routes.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,9 +465,7 @@ describe('admin-form.preview.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})

it('should return 400 when response is missing _id', async () => {
Expand All @@ -492,9 +490,7 @@ describe('admin-form.preview.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})

it('should return 400 when response is missing fieldType', async () => {
Expand All @@ -519,9 +515,7 @@ describe('admin-form.preview.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})

it('should return 400 when response has invalid fieldType', async () => {
Expand All @@ -548,9 +542,7 @@ describe('admin-form.preview.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})

it('should return 400 when response is missing answer', async () => {
Expand All @@ -575,9 +567,7 @@ describe('admin-form.preview.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})

it('should return 400 when response has both answer and answerArray', async () => {
Expand All @@ -602,9 +592,7 @@ describe('admin-form.preview.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})

it('should return 400 when attachment response has filename but not content', async () => {
Expand All @@ -629,9 +617,7 @@ describe('admin-form.preview.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})

it('should return 400 when attachment response has content but not filename', async () => {
Expand All @@ -656,9 +642,7 @@ describe('admin-form.preview.routes', () => {
.query({ captchaResponse: 'null' })

expect(response.status).toBe(400)
expect(response.body.message).toEqual(
'celebrate request validation failed',
)
expect(response.body.message).toEqual('Validation failed')
})
})

Expand Down
Loading