Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump helmet from 3.23.1 to 4.1.0 #233

Merged
merged 27 commits into from
Sep 16, 2020
Merged

fix(deps): bump helmet from 3.23.1 to 4.1.0 #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
44e931a
fix(deps): bump helmet from 3.23.1 to 4.1.0
dependabot[bot] Sep 2, 2020
b2a8bf7
chore: import nocache
tshuli Sep 2, 2020
e87055d
fix: merge conflicts
tshuli Sep 2, 2020
38b0441
fix: declare type of cspDirective
tshuli Sep 2, 2020
3ba2e40
test: check that helmet sets the correct headers
tshuli Sep 11, 2020
4f7fb12
fix: replace helmet.noCache with nocache
tshuli Sep 11, 2020
1b33872
docs: explain why if statement is necessary for optional directives
tshuli Sep 14, 2020
258e255
chore: improve tests
tshuli Sep 14, 2020
0d140b3
chore: update styleSrc in tests
tshuli Sep 14, 2020
d242b18
docs: link to helmetjs issue on falsey values
tshuli Sep 14, 2020
ccafdf3
chore: shift mock implementations to beforeEach
tshuli Sep 14, 2020
2cfe119
refactor: use mockReturnValue instead of mockImplementation
tshuli Sep 14, 2020
ea62812
chore: remove unnecessary mock function implementation which returns …
tshuli Sep 14, 2020
4887025
chore: simplify csp tests and make them stricter
tshuli Sep 14, 2020
c742f29
chore: use beforeAll and clearAllMocks
tshuli Sep 15, 2020
2d965bd
refactor: mockReturnValue instead of mockImplementation
tshuli Sep 15, 2020
3cd76f8
fix: set correct mockFeatureManager.props for !cspReportUri
tshuli Sep 15, 2020
602d145
refactor: shift cspCoreDirective constant up
tshuli Sep 15, 2020
d187865
chore: add tests for hsts
tshuli Sep 15, 2020
d148435
fix: use ContentSecurityPolicyOptions for type
tshuli Sep 15, 2020
ef661e0
refactor: filter for hsts middleware instead of using array index
tshuli Sep 15, 2020
3c34dd2
chore: include param for expect mockHelmet.hsts to have been called
tshuli Sep 16, 2020
9d92dd9
refactor: use find() instead of filter()
tshuli Sep 16, 2020
0de0863
fix: set correct default value for secure
tshuli Sep 16, 2020
8923104
chore: rename test folder
tshuli Sep 16, 2020
3d384cb
chore: check that next() is called correctly by hstsMiddleware
tshuli Sep 16, 2020
09bfb9a
chore: remove unnecessary mockReturnValue for mockHelmet.hsts
tshuli Sep 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 5 additions & 118 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@
"font-awesome": "4.7.0",
"glob": "^7.1.2",
"has-ansi": "^4.0.0",
"helmet": "^3.21.3",
"helmet": "^4.1.0",
"http-status-codes": "^2.1.2",
"intl-tel-input": "~12.1.6",
"json-stringify-deterministic": "^1.0.1",
Expand All @@ -139,6 +139,7 @@
"ng-infinite-scroll": "^1.3.0",
"ng-table": "^3.0.1",
"ngclipboard": "^2.0.0",
"nocache": "^2.1.0",
"node-cache": "^5.1.2",
"node-jose": "^1.0.0",
"nodemailer": "^6.4.11",
Expand Down Expand Up @@ -250,4 +251,4 @@
"webpack-merge": "^4.1.3",
"worker-loader": "^2.0.0"
}
}
}
Loading