chore(form-v2): add dependabot, run npm audit, move some packages to devDependencies #2313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note that react-scripts is also moved to devDependencies. CRA is a build tool and thus do not truly belong in dependencies. See their own argument: facebook/create-react-app#11102 this allows npm audit --production to raise any real vulnerabilities
mantariksh
approved these changes
Jul 6, 2021
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR includes a bunch of housekeeping, such as
form-v2/developbranch.npm auditandnpm updatebefore dependabot opens a bunch of PRs and gives @mantariksh PTSDnpm audit --productionbuild step in the future to prevent known vulnerabilities from slipping into our releasesRelated to #1904, but does not fully address it.