test: fix flaky form feedback test again #2241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
One of the unit tests for form feedback is still flaky despite many attempts to fix it (#1620, #2217).
Solution
I finally realised that the array of form feedback returned is inherently non-deterministic. This is because form feedback with identical timestamps can be returned in any order, but the service being tested subsequently adds an
indexkey depending on the order. This means there is no way for the test to exactly predict what the contents of the form feedback array should look like.The solution was to omit the
indexkey when checking for the shape of the form feedback array.