Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feature-manager): remove spcp-myinfo from feature manager #2222

Merged
merged 4 commits into from
Jun 22, 2021

Conversation

mantariksh
Copy link
Contributor

Removes Singpass, Corppass and MyInfo functionality from feature manager.

Part of #1842

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible

Manual tests

  • Create, activate and submit a Singpass form in email mode. Repeat for storage mode and decrypt the response.
  • Create, activate and submit a Corppass form in email mode. Repeat for storage mode and decrypt the response.
  • Create, activate and submit a MyInfo form in email mode

Tests

  • Singpass, Corppass and MyInfo functionality in dev environment works as expected

Deploy Notes

Note that the server will now fail to start up without the necessary env vars for Singpass, Corppass and MyInfo functionality. Defaults for Mockpass have been added to docker-compose for the dev environment.

@mantariksh mantariksh force-pushed the remove-fm/spcp-myinfo branch from e5d32b6 to f38d6dd Compare June 22, 2021 11:15
@mantariksh mantariksh changed the base branch from remove-fm/sms to develop June 22, 2021 11:15
@mantariksh mantariksh merged commit e6b163c into develop Jun 22, 2021
@mantariksh mantariksh deleted the remove-fm/spcp-myinfo branch June 23, 2021 03:06
@karrui karrui mentioned this pull request Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants