Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restore v3 API for retrieving individual admin form #2201

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

mantariksh
Copy link
Contributor

Restores changes from #2113, which were reverted in #2169.

  • Yes - this PR contains breaking changes
    • New client incompatible with old server due to new API endpoint
  • No - this PR is backwards compatible

* feat: add v3 API for retrieving admin form by id

* feat: remove `@routes` JSDoc line as they do not add info

and can be often wrong, and the real route is already lines away

* feat(AdminViewFormService): call v3 API to retrieve admin form

this allows us to eventually deprecate the old GET /adminform endpoints (and its ilk)
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ownself approve ownself

@mantariksh mantariksh merged commit 7908bbc into develop Jun 17, 2021
@tshuli tshuli mentioned this pull request Jun 22, 2021
@mantariksh mantariksh deleted the feat/restore-admin-v3-api branch June 23, 2021 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants