Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release v5.15.0 - webhook attachments #2176

Merged
merged 2 commits into from
Jun 17, 2021
Merged

Conversation

mantariksh
Copy link
Contributor

This release deploys the changes from #1713 in isolation. These changes were reverted in #2169 in order to minimise risk for release v5.14.0, and are now being redeployed.

@mantariksh
Copy link
Contributor Author

mantariksh commented Jun 15, 2021

Manual tests

  • Create a webhook receiving server with SDK version 0.9.0 which decrypts and prints the contents of attachments. Configure it to return 400 for the first request, and subsequently 200. Create a storage mode form with attachment fields, point the webhook URL to your receiving server and enable webhook retries. Check that the attachments are downloaded and decrypted correctly in both webhook attempts (the initial attempt which returns 400 and the first retry which returns 200).
  • Configure the server to only decrypt the content, ignoring the attachments. Check that decryption still works.
  • Remove the attachment field. Check that decryption still works when calling decrypt.
  • Remove the attachment field. Check that decryption still works when calling decryptWithAttachments.
  • Install SDK version <0.9.0 on the server and check that decryption works even when attachments are sent.
  • Install SDK version <0.9.0 on the server and check that decryption works when attachments are not sent.

frankchn and others added 2 commits June 15, 2021 18:34
* feat: Add webhook support for storage mode attachments

* fix tests post rebase

* remove merge error
@mantariksh mantariksh merged commit b728b42 into release Jun 17, 2021
@karrui karrui deleted the release-v5.15.0 branch August 17, 2021 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants