feat(design-system): complete Button, add IconButtons and update stories #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrui
force-pushed
the
form-v2/ds-colours
branch
from
5ed71c4 to
ab5aaf4
Compare
karrui
force-pushed
the
form-v2/buttons-components
branch
from
73d54f9 to
acc8d43
Compare
only for clear, outline, and reverse variants
karrui
force-pushed
the
form-v2/buttons-components
branch
from
e8bff49 to
3280c5f
Compare
karrui
changed the title
change color from .400 to .300
karrui
changed the title
* fix: remove transparent border from button * feat: allow button to take in textStyles * feat: add IconButton component and story * fix: correctly export IconButton * feat(IconButton): update icon sizing depending on size
karrui
changed the title
karrui
changed the title
karrui
added a commit
that referenced
this pull request
Jun 24, 2021
…ies (#2148) * feat(button): add active state styling to buttons * feat: update button stories * fix: remove unused imports, add lint rule * ref(Spinner): update rendering of Spinner to allow for Chakra props * feat(Button): allow for specific sizing of loading spinner icon * feat: update button theme to take into account color scheme only for clear, outline, and reverse variants * feat(story): update button stories (again) * feat(story): set default bg to distinguish clear and reverse variant * feat(story): remove center decorator * feat(Button): add Solid variant to supersede Primary, Danger, Success * style(Button): update minimum height to 2.75rem * feat(story): update stories for new button variants * feat(docs): update jsdoc of Button.colorScheme * feat: add sizing theming to Button * style(Button): update styling of button when disabled change color from .400 to .300 * style(button): add correct styling if isFullWidth prop is passed in * fix: remove transparent border from button * feat: allow button to take in textStyles * feat(design-system): add IconButton component and story (#2172) * fix: remove transparent border from button * feat: allow button to take in textStyles * feat: add IconButton component and story * fix: correctly export IconButton * feat(IconButton): update icon sizing depending on size
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR adds styling for the button active state. Stories have also been updated.
Also add
colorSchemetheming foroutline,clear, andreversevariants after discussion with @pearlyongThe colorScheme update is to prepare the theming for
IconButtoncomponent coming in a next PRCloses #1997
Solution
Features: