Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(feature-manager): remove Sentry from feature manager #2130

Merged
merged 2 commits into from
Jun 11, 2021
Merged

feat(feature-manager): remove Sentry from feature manager #2130

merged 2 commits into from
Jun 11, 2021

Conversation

mantariksh
Copy link
Contributor

Problem

Part of #1842

Solution

Removes Sentry configuration from feature manager.

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible
    • Server-side only

Deploy Notes

Note that the server will now crash in the absence of the following environment variables:

  • SENTRY_CONFIG_URL
  • CSP_REPORT_URI

karrui
karrui approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; might need a final PR to update our DEPLOYMENT_SETUP.md

@mantariksh mantariksh changed the base branch from test/remove-e2e-basic-env to develop June 10, 2021 07:11
@mantariksh mantariksh merged commit d087588 into develop Jun 11, 2021
@mantariksh mantariksh mentioned this pull request Jun 15, 2021
Merged
@mantariksh mantariksh deleted the remove-fm/sentry branch June 15, 2021 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrui karrui karrui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mantariksh @karrui