Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: loosen URL check in e2e test #2119

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Conversation

mantariksh
Copy link
Contributor

Problem

End-to-end tests are intermittently failing due to the following:

AssertionError: expected
      'http://localhost:5000/60c068423668141b03289c84#!/' to deeply equal
      'http://localhost:5000/#!/60c068423668141b03289c84'
      + expected - actual
      -http://localhost:5000/60c068423668141b03289c84#!/
      +http://localhost:5000/#!/60c068423668141b03289c84

This is probably because the test checks the URL in the browser before the browser redirects to the form.

Solution

Loosen the URL check so it checks for the presence of the form ID in the URL instead of an exact string. If the redirect does not occur correctly then the subsequent assertions will fail anyway.

@mantariksh mantariksh requested a review from karrui June 9, 2021 09:53
@mantariksh mantariksh merged commit b1395fa into develop Jun 9, 2021
@mantariksh mantariksh deleted the test/loosen-e2e-url branch June 10, 2021 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants