Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: formFactoryClientService #2117

Merged
merged 3 commits into from
Jun 10, 2021
Merged

refactor: formFactoryClientService #2117

merged 3 commits into from
Jun 10, 2021

Conversation

chowyiyin
Copy link
Contributor

This PR replaces form-factory.client.service.js and directly calls FormApi in create-form-modal.client.controller

Closes #1836

Tests

  • Duplicate any form. Ensure duplicate form modal appears and duplicated form appears on the dashboard upon completion.
  • Create a form from scratch in storage mode and email mode. Should be redirected to edit page with no existing fields. Check that form appears on dashboard.
  • Select create new form and select any covid template. Modal with template form in public view should be displayed. Select "Use Template", and follow steps to create form. Ensure relevant form fields are present on edit page.
  • Select any template under examples. Select "Use Template", and follow steps to create form. Ensure relevant form fields are present on edit page.

mantariksh
mantariksh approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@mantariksh mantariksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, do test before merging

@chowyiyin chowyiyin merged commit 17f2f25 into develop Jun 10, 2021
@chowyiyin chowyiyin deleted the refactor/formFactoryClientService branch June 10, 2021 01:36
@mantariksh mantariksh mentioned this pull request Jun 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantariksh mantariksh mantariksh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert form-factory.client.service.js to TypeScript
2 participants
@chowyiyin @mantariksh