Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(formApiClientFactory): rearrange types #2061

Merged
merged 5 commits into from
Jun 3, 2021
Merged

refactor(formApiClientFactory): rearrange types #2061

merged 5 commits into from
Jun 3, 2021

Conversation

chowyiyin
Copy link
Contributor

This PR is a continuation of the FormApi refactor. This PR rearranges the directory of types to remove dependencies across src/app and src/public.

Solution

  • DuplicateFormBody, UpdateFormParams and PublicFormViewDto were shifted to types/api/form.ts
  • IPossiblyPrefilledField was shifted to types/field/myinfoField.ts
  • EditFormFieldParams was shifted to types/api/field.ts

@chowyiyin chowyiyin changed the title refactor: refactor(formApiClientFactory): rearrange types Jun 3, 2021
@chowyiyin chowyiyin marked this pull request as ready for review June 3, 2021 05:52
@chowyiyin chowyiyin changed the base branch from refactor/formApiClientFactory to develop June 3, 2021 07:06
@mantariksh mantariksh mentioned this pull request Jun 3, 2021
Merged
18 tasks
@chowyiyin chowyiyin force-pushed the refactor/formApiClientFactoryTypes branch from c168555 to 68cd93d Compare June 3, 2021 07:28
@chowyiyin chowyiyin merged commit 9f34c8b into develop Jun 3, 2021
@chowyiyin chowyiyin deleted the refactor/formApiClientFactoryTypes branch June 3, 2021 09:15
@karrui karrui mentioned this pull request Jun 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantariksh mantariksh mantariksh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chowyiyin @mantariksh