refactor(submissions.client.factory): extract admin form features #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seaerchin
requested review from
liangyuanruo,
mantariksh,
karrui,
chowyiyin,
tshuli and
yong-jie
… typings to count submissions
…h countFormSubmissions
seaerchin
force-pushed
the
refactor/extract-admin-submissions
branch
from
6f2da95 to
2089db1
Compare
chowyiyin
reviewed
May 28, 2021
karrui
reviewed
Jun 1, 2021
src/public/modules/forms/admin/directives/settings-form.client.directive.js
Show resolved
Hide resolved
mantariksh
reviewed
Jun 2, 2021
src/public/modules/forms/admin/directives/settings-form.client.directive.js
Outdated
Show resolved
Hide resolved
…ery and associated methods
….mock with mocked using mockAxios impacted readability and understanding so it was changed to use jest.mock (which mocks the whole module) together with mocked from ts-jest to mock return values
karrui
approved these changes
Jun 7, 2021
This was referenced Jun 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
submissions.client.factoryclient-side service that determines the performance and safety of many key features, but has two separate areas of concern - the public form facing submissions and the admin form retrieval of submissions.Part 1 of #1874
Solution
This extracts out all the straight forward client submission methods to
AdminFormService, and replaces old method calls with the new one.The download related methods will be in a separate PR for closer scrutiny!
Breaking Changes
Tests
This adds unit tests for all new methods added.
Manual Tests
This has been already tested on staging
Create a storage mode form with any field and activate it. Submit the form >= 11 times. Go to the data section and unlock responses.
referenceId. this should work and clicking into the response should display all related data.referenceId. There should be no responses displayed.