Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pull_request_template): adds breaking changes section to github template #1915

Merged
merged 4 commits into from
May 18, 2021

Conversation

seaerchin
Copy link
Contributor

Problem

Devs are supposed to indicate breaking changes for easier rollback if hiccups occur on the release day. This makes it prone to human error, where the devs forget.

Solution

adds a breaking change section to the PR template

@seaerchin seaerchin requested review from mantariksh, karrui and tshuli May 18, 2021 03:30
@seaerchin seaerchin requested a review from karrui May 18, 2021 03:49
@seaerchin seaerchin requested a review from karrui May 18, 2021 03:56
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with niot

.github/pull_request_template.md Outdated Show resolved Hide resolved
@seaerchin seaerchin merged commit 87ef9c1 into develop May 18, 2021
@seaerchin seaerchin deleted the docs/PR-template branch May 18, 2021 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants