-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(verification): migrate verified field #1866
Conversation
src/app/routes/api/v3/forms/__tests__/public-forms.verification.routes.spec.ts
Show resolved
Hide resolved
await dbHandler.clearDatabase() | ||
|
||
// Form without verifiable fields | ||
const { form: emptyForm } = await dbHandler.insertEmailForm() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may want to inline this since this is only used in a single test. Same for the verifiable form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i didn't do this cos it'll be reused for the related endpoints in the issues @__@ if it's an issue, i can change it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Problem
Part 1 of #1522
This migrates the first
/POST
endpoint to the new API v3 route. This allows for us to shift our new routes to be grouped together and allows us to follow a RESTful api structure.Solution
Shift the old endpoint to be rooted at
/api/v3
and change the structure of the route so that the form id is passed as a parameter in the URLTests
Ported over existing tests and changed them so that the
formId
parameter exists on the requestManual Test