-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: store only user ID in session #1849
Conversation
Might want to fix tests! Check that we do not retrieve the user id in session with the EDIT: I checked, no usages of id anywhere for the session user, now we just need to fix the tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, in src/app/loaders/express/logging.ts
, we have a getter for session.user._id for logging and that may break if we don't update that too
Don't need to do this, since we are just removing everything from session.user except for _id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be ok now, just need to fix the build error (remove the user.email call (since session doesn't contain the full user anymore) and replace it with _id i guess))
also search the codebase for instances of TODO(#212)
and remove them! :D
@karrui Do you mean the line containing: |
email is now removed from the logged in user
@jia1 I've fixed it, can check out my commit for more info! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closes #212