Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump @types/bcrypt from 3.0.1 to 5.0.0 #1830

Merged
merged 2 commits into from
May 10, 2021
Merged

chore(deps-dev): bump @types/bcrypt from 3.0.1 to 5.0.0 #1830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57bf599
chore(deps-dev): bump @types/bcrypt from 3.0.1 to 5.0.0
dependabot[bot] May 9, 2021
d1455de
fix: update types for bcrypt wrappers
mantariksh May 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 41 additions & 36 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"angular-ui-bootstrap": "~2.5.6",
"angular-ui-router": "~1.0.29",
"aws-info": "^1.2.0",
"aws-sdk": "^2.901.0",
"aws-sdk": "^2.903.0",
"axios": "^0.21.1",
"bcrypt": "^5.0.1",
"bluebird": "^3.5.2",
Expand Down Expand Up @@ -161,7 +161,7 @@
"@babel/plugin-transform-runtime": "^7.13.15",
"@babel/preset-env": "^7.14.1",
"@opengovsg/mockpass": "^2.6.9",
"@types/bcrypt": "^3.0.1",
"@types/bcrypt": "^5.0.0",
"@types/bluebird": "^3.5.34",
"@types/busboy": "^0.2.3",
"@types/compression": "^1.7.0",
Expand Down Expand Up @@ -205,7 +205,7 @@
"csv-parse": "^4.15.4",
"date-fns": "^2.21.3",
"env-cmd": "^10.1.0",
"eslint": "^7.25.0",
"eslint": "^7.26.0",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-angular": "^4.0.1",
"eslint-plugin-import": "^2.22.1",
Expand Down
4 changes: 2 additions & 2 deletions src/app/utils/hash.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export class HashingError extends ApplicationError {
* @returns err(ApplicationError) if hashing error occurs
*/
export const hashData = (
dataToHash: unknown,
dataToHash: string | Buffer,
logMeta: Record<string, unknown> = {},
saltRounds?: number,
): ResultAsync<string, HashingError> => {
Expand Down Expand Up @@ -56,7 +56,7 @@ export const hashData = (
* @returns err(ApplicationError) if error occurs whilst comparing hashes
*/
export const compareHash = (
data: unknown,
data: string | Buffer,
encrypted: string,
logMeta: Record<string, unknown> = {},
): ResultAsync<boolean, HashingError> => {
Expand Down