Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: align joi validation types to schema #1800

Merged
merged 4 commits into from
May 10, 2021
Merged

fix: align joi validation types to schema #1800

merged 4 commits into from
May 10, 2021

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented May 5, 2021 •
edited
Loading

Problem

@tshuli tshuli requested a review from mantariksh May 5, 2021 06:58
@tshuli tshuli requested a review from mantariksh May 6, 2021 05:43
@tshuli
Copy link
Contributor Author

tshuli commented May 6, 2021

@mantariksh thanks for reviewing, for your re-review pls

mantariksh
mantariksh reviewed May 6, 2021
View reviewed changes
src/app/modules/form/admin-form/admin-form.controller.ts Outdated Show resolved Hide resolved
src/types/form_logic.ts Outdated Show resolved Hide resolved
@tshuli
Copy link
Contributor Author

tshuli commented May 6, 2021

@mantariksh thanks for reviewing, for your re-review pls

@tshuli tshuli merged commit de65916 into develop May 10, 2021
@karrui karrui mentioned this pull request May 11, 2021
Merged
@karrui karrui deleted the logic-joi branch May 11, 2021 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantariksh mantariksh mantariksh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LogicDto is typed incorrectly
2 participants
@tshuli @mantariksh