feat(admin-form): individual form field api #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seaerchin
changed the title
seaerchin
requested review from
karrui and
mantariksh
and removed request for
karrui
…on of Rating field
seaerchin
force-pushed
the
refactor/extract-form-field-view
branch
from
8083454 to
5f12cab
Compare
mantariksh
approved these changes
May 6, 2021
|
just leaving this comment here to remind myself that this is my first PR without any comments HAHAHHA |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Individual form fields require their own endpoint to disentangle their logic from other unrelated logic in forms, such as the settings/collaborators.
Closes #1498
Solution
This adds a new GET endpoint for individual fields
Tests
Added unit and integration tests for
/fields/:fieldIdbut there are no manual tests. This is because the frontend is still using the whole admin form object to update the UI