Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract create logic endpoint / refactor $watchCollection #1796

Merged
merged 18 commits into from
May 17, 2021

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented May 5, 2021

Problem

Tests

Create Logic Endpoint

  • Create a showFields logic. Check that logic is successfully added and build tab is successfully updated (hidden fields greyed out).
  • Repeat the above with a second logic

Test using manual API calls

  • Check that endpoint returns 404 when formId is incorrect

$watchCollection Refactor

  • Create a form with multiple showFields logic. Delete one of them. Check that the Build tab is updated correctly (field should no longer be greyed out)
  • Now change one of the logic to preventSubmit. Check that the Build tab is updated correctly (field should no longer be greyed out). Change it back to showFields. Check that the field is now greyed out on build tab

@tshuli tshuli force-pushed the ref/update-logic-api-2 branch from 7143126 to fa9562a Compare May 5, 2021 03:09
@tshuli tshuli force-pushed the ref/create-logic-api branch 2 times, most recently from a0abf62 to c69da61 Compare May 5, 2021 03:57
@tshuli tshuli changed the title refactor: extract create logic endpoint refactor: extract create logic endpoint / refactor $watchCollection May 5, 2021
@tshuli tshuli force-pushed the ref/create-logic-api branch from c69da61 to 0772db0 Compare May 5, 2021 04:07
@tshuli tshuli changed the base branch from ref/update-logic-api-2 to develop May 5, 2021 04:07
@tshuli tshuli force-pushed the ref/create-logic-api branch 2 times, most recently from f06c306 to 6460c97 Compare May 6, 2021 02:55
@tshuli tshuli force-pushed the ref/create-logic-api branch 3 times, most recently from def85db to bd0a59a Compare May 10, 2021 07:59
@tshuli tshuli requested review from mantariksh and karrui May 11, 2021 01:43
@tshuli
Copy link
Contributor Author

tshuli commented May 11, 2021

@mantariksh thanks for reviewing, for re-review pls

@tshuli tshuli requested a review from mantariksh May 11, 2021 06:30
@tshuli tshuli force-pushed the ref/create-logic-api branch from 080187d to ae079a8 Compare May 12, 2021 07:41
@tshuli tshuli requested a review from karrui May 12, 2021 07:41
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with nits

src/public/services/AdminFormService.ts Outdated Show resolved Hide resolved
src/types/form.ts Outdated Show resolved Hide resolved
@karrui
Copy link
Contributor

karrui commented May 12, 2021

Maybe rebase on dev for the new Github Actions :P

@tshuli tshuli force-pushed the ref/create-logic-api branch from ae079a8 to 34d09ca Compare May 17, 2021 01:50
@tshuli tshuli merged commit fd5a8f6 into develop May 17, 2021
@karrui karrui deleted the ref/create-logic-api branch August 17, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] Extract create logic endpoint from PUT /:formId/adminform
4 participants