-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: extract create logic endpoint / refactor $watchCollection #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshuli
force-pushed
the
ref/update-logic-api-2
branch
from
May 5, 2021 03:09
7143126
to
fa9562a
Compare
tshuli
force-pushed
the
ref/create-logic-api
branch
2 times, most recently
from
May 5, 2021 03:57
a0abf62
to
c69da61
Compare
tshuli
changed the title
refactor: extract create logic endpoint
refactor: extract create logic endpoint / refactor $watchCollection
May 5, 2021
tshuli
force-pushed
the
ref/create-logic-api
branch
from
May 5, 2021 04:07
c69da61
to
0772db0
Compare
tshuli
force-pushed
the
ref/create-logic-api
branch
2 times, most recently
from
May 6, 2021 02:55
f06c306
to
6460c97
Compare
seaerchin
reviewed
May 6, 2021
tshuli
force-pushed
the
ref/create-logic-api
branch
3 times, most recently
from
May 10, 2021 07:59
def85db
to
bd0a59a
Compare
mantariksh
reviewed
May 11, 2021
@mantariksh thanks for reviewing, for re-review pls |
karrui
reviewed
May 12, 2021
src/app/modules/form/admin-form/__tests__/admin-form.service.spec.ts
Outdated
Show resolved
Hide resolved
src/public/modules/forms/admin/controllers/edit-logic-modal.client.controller.js
Outdated
Show resolved
Hide resolved
tshuli
force-pushed
the
ref/create-logic-api
branch
from
May 12, 2021 07:41
080187d
to
ae079a8
Compare
karrui
approved these changes
May 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with nits
Maybe rebase on dev for the new Github Actions :P |
…by recreating form_logics array
tshuli
force-pushed
the
ref/create-logic-api
branch
from
May 17, 2021 01:50
ae079a8
to
34d09ca
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Tests
Create Logic Endpoint
Test using manual API calls
$watchCollection Refactor