fix: update MyInfo field count correctly, show correct error #1738
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Fixing error message
The initial error message was:
This was fixed by accessing
error.response.status
rather thanerror.status
, sinceerror
is now anAxiosError
.The error message then changed to this:
This was because we return a 422 when an error occurs while editing fields, and the
switch
case handles 422s by attempting to accesserror.data.message
. This was fixed by accessingerror.response.data.message
instead.This finally fixed the error message:
Updating MyInfo field count
This was fixed by assigning to
$scope.myform.form_fields
instead of pushing to the array, which triggers the AngularJS digest cycle correctly.